Changes to support latent MoEs #2296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakn94
force-pushed
the
dnarayanan/latent_moe
branch
from
d088236 to
b0a2d8c
Compare
venmugil
suggested changes
Nov 21, 2025
| # Project the output back from latent dimension to hidden dimension after combine | ||
| # in latent dimension. | ||
| if self.config.moe_latent_size: | ||
| output, _ = self.fc2_latent_proj(output) |
There was a problem hiding this comment.
fc2_latent_proj might return a bias if self.config.add_bias_linear is set.
Contributor
Author
There was a problem hiding this comment.
Good point. But what should be the right behavior here if this layer does have a bias?
| if self.config.moe_latent_size and mlp_bias is not None: | ||
| output = output + mlp_bias | ||
| mlp_bias = None | ||
| output = self.combine(output, shared_expert_output) |
There was a problem hiding this comment.
output will be in latent dimension, while shared_expert_output will be in hidden dimension here. We may have to move self.fc2_latent_proj inside self.combine before the addition of output and shared_expert_output.
Contributor
Author
There was a problem hiding this comment.
Good point, moved.
Signed-off-by: Deepak Narayanan <[email protected]>
…tent-size Signed-off-by: Deepak Narayanan <[email protected]>
… right shape Signed-off-by: Deepak Narayanan <[email protected]>
deepakn94
force-pushed
the
dnarayanan/latent_moe
branch
from
b0a2d8c to
4463081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.