Skip to content

Conversation

@dimapihtar
Copy link
Contributor

What does this PR do ?

Adds FIM dataset support.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: dimapihtar <[email protected]>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar dimapihtar marked this pull request as ready for review November 18, 2025 18:59
@dimapihtar dimapihtar requested review from a team as code owners November 18, 2025 18:59
@dimapihtar
Copy link
Contributor Author

/ok to test efa6ac7

Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
Copy link
Contributor Author

/ok to test 5b8d7eb

Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
Copy link
Contributor Author

/ok to test 0a2ad73

@dimapihtar dimapihtar enabled auto-merge November 21, 2025 13:31
@dimapihtar dimapihtar added this pull request to the merge queue Nov 21, 2025
Merged via the queue into NVIDIA:main with commit 7994405 Nov 21, 2025
128 of 136 checks passed
@dimapihtar dimapihtar deleted the fim_dataset_support branch November 21, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants