Skip to content

Conversation

@Autumn1998
Copy link
Contributor

@Autumn1998 Autumn1998 commented Nov 18, 2025

What does this PR do ?

Fix bug in configuration validation.
Use the official DeepEP instead of the private repository.
Related PR in dev branch: #2287

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Autumn1998 Autumn1998 requested review from a team as code owners November 18, 2025 05:00
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Autumn1998 Autumn1998 self-assigned this Nov 18, 2025
@Autumn1998 Autumn1998 added the bug Something isn't working label Nov 18, 2025
@Autumn1998
Copy link
Contributor Author

/ok to test 6094ebe

@Autumn1998
Copy link
Contributor Author

/ok to test 6c31b39

@Autumn1998 Autumn1998 changed the title hot fix, use offical DeepEP [HOT FIX] Fix bug of hybrid-ep backend in flex-dispatcher Nov 18, 2025
@yanring yanring added the Final Review Apply this label to indicate that your PR is ready for final review. label Nov 18, 2025
@Autumn1998
Copy link
Contributor Author

/ok to test 6c31b39

@chtruong814 chtruong814 added this pull request to the merge queue Nov 24, 2025
Merged via the queue into NVIDIA:main with commit 326ec8c Nov 24, 2025
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Final Review Apply this label to indicate that your PR is ready for final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants