Skip to content

cg condition fix #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: core_dev_r0.15.0
Choose a base branch
from
Open

cg condition fix #2213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion megatron/core/models/common/language_module/language_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def compute_language_model_loss(self, labels: Tensor, logits: Tensor) -> Tensor:
is_cg_capturable = (
hasattr(self.config, 'cuda_graph_scope')
and self.config.cuda_graph_scope
and 'full_iteration' in self.config.cuda_graph_scope
and (self.config.cuda_graph_scope is not None and 'full_iteration' in self.config.cuda_graph_scope)
Copy link
Contributor

@ananthsub ananthsub Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant with L141, which will check if None or if the list is empty

)
if is_cg_capturable and not is_te_min_version("2.7.0"):
from megatron.core.utils import get_te_version
Expand Down