Skip to content

Conversation

@Victarry
Copy link
Contributor

@Victarry Victarry commented Nov 7, 2025

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Added Test Cases

Proxy Models:

  • Deepseek-V3 with reduced number of experts
  • Mixtral-8x7B

Token dispatcher:

  • Alltoall
  • DeepEP
  • HybridEP

Precision:

  • BF16
  • FP8

How this PR compare performance with baseline values

  1. For each testcase, we run forward and backward 20 steps(after 3 warmup steps).
  2. Collect the mean and std values of fwd/bwd latency from the 20 steps, the top3 values will be excluded for calculation.
    1. Assert (mean_latency / baselind_mean_latency) < 1.02 to guard performance regression.
    2. Assert (mean_latency / std_latency) < 1.02` to remove noisy test metrics.
  3. Due to the intrinsic variance of hardware performance, we allow for 5 reruns after failure.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Victarry Victarry requested review from a team as code owners November 7, 2025 09:59
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 7, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Victarry Victarry marked this pull request as draft November 7, 2025 09:59
@Victarry Victarry marked this pull request as ready for review November 7, 2025 10:06
@Victarry
Copy link
Contributor Author

Victarry commented Nov 7, 2025

/ok to test d9ef668

@Victarry
Copy link
Contributor Author

Victarry commented Nov 7, 2025

/ok to test 306b9c1

Comment on lines 83 to 87
seq_length=4096,
micro_batch_size=1,
hidden_size=7168,
moe_ffn_hidden_size=2048,
num_experts=64,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: change num_experts to 32 to align with actual training. (num_local_experts = 4)

@yanring yanring changed the title [Dev] Add performance test for MoE layer [Dev] test(MoE): Add performance test for MoE layer Nov 13, 2025
@Victarry Victarry marked this pull request as draft November 13, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants