Skip to content

Conversation

@Wohox
Copy link
Contributor

@Wohox Wohox commented Nov 7, 2025

What does this PR do ?

EP Overlap brings extra cpu overhead and may cause GPU bubble during execution, partial CUDA graph helps release cpu pressure within the selected scope. This PR supports partial CUDA graph for EP Overlap, the supported scopes are attn, moe_router, moe_preprocess (moe and mlp are not supported).

Usage
To enable this feature, refer to the following example:

--overlap-moe-expert-parallel-comm \
--delay-wgrad-compute \
--cuda-graph-scope attn moe_router moe_preprocess \

(--delay-wgrad-compute is optional)

Correctness
The loss value can be bitwise aligned when enable & disable partial CUDA graph.
Screenshot 2025-11-07 at 11 55 01

This PR is for dev branch and the PR for main branch is in PR2184

Dependencies
enable CUDA graph with delay-wgrad-compute relies on TE PR:

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Wohox Wohox requested review from a team as code owners November 7, 2025 04:46
@ko3n1g ko3n1g added this to the Core 0.16 milestone Nov 7, 2025
@Wohox Wohox changed the title Pingtian/1f1b cuda graph rebase dev signed [Dev] Partial CUDA Graph support for EP Overlap Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development module: moe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants