Skip to content

Conversation

@cuichenx
Copy link
Contributor

@cuichenx cuichenx commented Oct 29, 2025

What does this PR do ?

Various minor fixes for gpt-oss model

  1. Fix yarn mscale to match with HF implementation and disable rope fusion when mscale is used.
  2. Initialize softmax offset on GPU
  3. Remove lru cache for attention mask to prevent OOM with long sequence lengths
    Works with Add gpt-oss finetune recipes + fixes NVIDIA-NeMo/Megatron-Bridge#1155

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Chen Cui <[email protected]>
@cuichenx cuichenx requested review from a team as code owners October 29, 2025 23:07
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cuichenx
Copy link
Contributor Author

/ok to test c5b1e1e

@cuichenx
Copy link
Contributor Author

/ok to test eedb6bb

Signed-off-by: Chen Cui <[email protected]>
@cuichenx cuichenx requested a review from a team as a code owner October 31, 2025 20:39
@kvareddy kvareddy requested a review from santhnm2 November 13, 2025 10:06
@kvareddy
Copy link
Contributor

@santhnm2, can you please take a look at this MR?

@cuichenx cuichenx added Final Review Apply this label to indicate that your PR is ready for final review. and removed Expert Review Apply this label to indicate that your PR is ready for expert review. labels Nov 20, 2025
@chtruong814 chtruong814 added this pull request to the merge queue Nov 22, 2025
Merged via the queue into NVIDIA:main with commit 9873958 Nov 22, 2025
50 of 52 checks passed
@sbhavani sbhavani mentioned this pull request Nov 25, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Review Apply this label to indicate that your PR is ready for final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants