Skip to content

Conversation

@itsomri
Copy link
Collaborator

@itsomri itsomri commented Jan 6, 2026

Description

This PR:

  1. Adds an "examples" dir
  2. Allows importing CRD definitions to binary for env-tests. This lets us compile a portable version of time-aware-simulator, that can be run without assuming location of CRD file directory
  3. Splits e2e script to cluster creation an e2e. This lets us quickly create kind environments locally for dev/test. Original script maintains the same API.

Checklist

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/deployments/kai-scheduler/crds 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 75.68% (-0.79%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/deployments/kai-scheduler/crds/embed.go 0.00% (ø) 15 (+15) 0 15 (+15)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/setup.go 75.68% (-0.79%) 37 (+3) 28 (+2) 9 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@itsomri itsomri force-pushed the omric/examples-dir branch from ac2e59f to f166863 Compare January 6, 2026 13:31
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/deployments/kai-scheduler/crds 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 75.68% (-0.79%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/deployments/kai-scheduler/crds/embed.go 0.00% (ø) 15 (+15) 0 15 (+15)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/setup.go 75.68% (-0.79%) 37 (+3) 28 (+2) 9 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@itsomri itsomri enabled auto-merge (squash) January 6, 2026 15:12
@itsomri itsomri force-pushed the omric/examples-dir branch from f166863 to 57bb255 Compare January 7, 2026 12:29
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/deployments/kai-scheduler/crds 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 75.68% (-0.79%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/deployments/kai-scheduler/crds/embed.go 0.00% (ø) 15 (+15) 0 15 (+15)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/setup.go 75.68% (-0.79%) 37 (+3) 28 (+2) 9 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@itsomri itsomri merged commit c758858 into main Jan 7, 2026
7 checks passed
@itsomri itsomri deleted the omric/examples-dir branch January 7, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants