Skip to content

Conversation

@rich7420
Copy link
Contributor

Description

This PR changed error handling in snapshotStorageCapacities() to gracefully skip invalid CSIStorageCapacity objects with a warning log instead of failing the entire snapshot, allowing the scheduler to continue with valid capacities.
If i'm wrong plz correct me.

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info 83.89% (-0.50%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/storage.go 79.21% (-0.79%) 101 (+1) 80 21 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info 84.17% (-0.21%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/storage.go 79.21% (-0.79%) 101 (+1) 80 21 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@rich7420 rich7420 force-pushed the todo-graceful-handle-error branch from 34123ed to 48cb882 Compare January 5, 2026 02:22
@romanbaron romanbaron force-pushed the todo-graceful-handle-error branch from 48cb882 to 00c4cb5 Compare January 7, 2026 10:19
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info 84.08% (-0.21%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/storage.go 79.21% (-0.79%) 101 (+1) 80 21 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@itsomri itsomri merged commit f16abeb into NVIDIA:main Jan 7, 2026
6 of 7 checks passed
@itsomri itsomri mentioned this pull request Jan 7, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants