Skip to content

Conversation

@itsomri
Copy link
Collaborator

@itsomri itsomri commented Nov 17, 2025

Description

This PR allows fraction container name and type to be specified in pod annotations, letting the user set other containers than the first one.

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated CHANGELOG.md (if needed)
  • Updated documentation (if needed)

@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/admission/webhook/v1alpha2/gpusharing 90.00% (+67.78%) 🌟
github.com/NVIDIA/KAI-scheduler/pkg/binder/common 13.98% (-3.59%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/binder/plugins/gpusharing 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/common/constants 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/admission/webhook/v1alpha2/gpusharing/gpu_sharing.go 90.00% (+67.78%) 20 (+2) 18 (+14) 2 (-12) 🌟
github.com/NVIDIA/KAI-scheduler/pkg/binder/common/gpu_access.go 0.00% (ø) 71 (+19) 0 71 (+19)
github.com/NVIDIA/KAI-scheduler/pkg/binder/plugins/gpusharing/gpu_sharing.go 0.00% (ø) 32 (+2) 0 32 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/common/constants/constants.go 0.00% (ø) 2 0 2

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/admission/webhook/v1alpha2/gpusharing/gpu_sharing_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/binder/plugins/gpusharing/gpu_sharing_test.go

@itsomri itsomri force-pushed the omric/feat-specify-fraction-container-index branch from 0105d4f to 27e5b54 Compare November 17, 2025 14:07
davidLif
davidLif previously approved these changes Nov 17, 2025
@itsomri itsomri enabled auto-merge (squash) November 17, 2025 14:10
@itsomri itsomri force-pushed the omric/feat-specify-fraction-container-index branch from 27e5b54 to 182b510 Compare November 17, 2025 14:30
@itsomri itsomri merged commit 6282e04 into main Nov 17, 2025
4 checks passed
@itsomri itsomri deleted the omric/feat-specify-fraction-container-index branch November 17, 2025 15:00
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/admission/webhook/v1alpha2/gpusharing 90.00% (+67.78%) 🌟
github.com/NVIDIA/KAI-scheduler/pkg/binder/common 13.98% (-3.59%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/binder/plugins/gpusharing 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/common/constants 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/admission/webhook/v1alpha2/gpusharing/gpu_sharing.go 90.00% (+67.78%) 20 (+2) 18 (+14) 2 (-12) 🌟
github.com/NVIDIA/KAI-scheduler/pkg/binder/common/gpu_access.go 0.00% (ø) 71 (+19) 0 71 (+19)
github.com/NVIDIA/KAI-scheduler/pkg/binder/plugins/gpusharing/gpu_sharing.go 0.00% (ø) 32 (+2) 0 32 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/common/constants/constants.go 0.00% (ø) 2 0 2

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/admission/webhook/v1alpha2/gpusharing/gpu_sharing_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/binder/plugins/gpusharing/gpu_sharing_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants