Skip to content

Conversation

@davidLif
Copy link
Collaborator

Description

Bug fix - HasMatchingPlugin should return true for cases without wildcard.

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • [V] Self-reviewed
  • [V] Added/updated tests (if needed)
  • Updated CHANGELOG.md (if needed)
  • Updated documentation (if needed)

@davidLif davidLif changed the title bug(podgrouper) - HasMatchingPlugin for the default hub should return true for exact matches fix(podgrouper) - HasMatchingPlugin for the default hub should return true for exact matches Nov 17, 2025
@davidLif davidLif enabled auto-merge (squash) November 17, 2025 12:11
@davidLif davidLif changed the title fix(podgrouper) - HasMatchingPlugin for the default hub should return true for exact matches fix(podgrouper): HasMatchingPlugin for the default hub should return true for exact matches Nov 17, 2025
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 93.33% (+11.19%) 🎉

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 93.33% (+11.19%) 30 (+2) 28 (+5) 2 (-3) 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub_test.go

@davidLif davidLif force-pushed the DavidL/33282/fixHasMatchingPlugin branch from 6924425 to c06ae64 Compare November 17, 2025 14:20
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 93.33% (+11.19%) 🎉

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 93.33% (+11.19%) 30 (+2) 28 (+5) 2 (-3) 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub_test.go

@davidLif davidLif force-pushed the DavidL/33282/fixHasMatchingPlugin branch from c06ae64 to 6522a5a Compare November 17, 2025 14:52
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 93.33% (+11.19%) 🎉

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 93.33% (+11.19%) 30 (+2) 28 (+5) 2 (-3) 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub_test.go

@davidLif davidLif force-pushed the DavidL/33282/fixHasMatchingPlugin branch from 6522a5a to 7b372b5 Compare November 17, 2025 16:10
@davidLif davidLif merged commit 1eab535 into main Nov 17, 2025
4 checks passed
@davidLif davidLif deleted the DavidL/33282/fixHasMatchingPlugin branch November 17, 2025 16:41
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 93.33% (+11.19%) 🎉

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 93.33% (+11.19%) 30 (+2) 28 (+5) 2 (-3) 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants