Skip to content

Conversation

@enoodle
Copy link
Collaborator

@enoodle enoodle commented Nov 13, 2025

Description

Latest GPU-operator (v25.10.0) changed the way CDI is enabled in the ClusterPolicy by deprecating the default field. This will check the GPU operator version set in a label on the ClusterPolicy object and ignore this field if needed.

Related Issues

Fixes #

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated CHANGELOG.md (if needed)
  • Updated documentation (if needed)

Breaking Changes

None, this will improve support for different GPU-operator versions

Additional Notes

@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder 72.27% (-1.01%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder/resources.go 73.00% (-1.23%) 100 (+3) 73 (+1) 27 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@enoodle enoodle force-pushed the erez/support-gpu-operator-25-10-0-better branch from e380296 to b0c3f51 Compare November 13, 2025 10:42
@enoodle enoodle marked this pull request as ready for review November 13, 2025 10:43
@enoodle enoodle force-pushed the erez/support-gpu-operator-25-10-0-better branch from 33ccb26 to de120da Compare November 13, 2025 10:43
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder 74.79% (+1.51%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder/resources.go 76.00% (+1.77%) 100 (+3) 76 (+4) 24 (-1) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder/binder_test.go

@enoodle enoodle merged commit 0767a6d into main Nov 13, 2025
4 checks passed
@enoodle enoodle deleted the erez/support-gpu-operator-25-10-0-better branch November 13, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants