Skip to content

Conversation

@itsomri
Copy link
Collaborator

@itsomri itsomri commented Nov 12, 2025

Description

This PR documents the time aware fairness feature in KAI.

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated CHANGELOG.md (if needed)
  • Updated documentation (if needed)

Breaking Changes

N/A

Additional Notes

N/A

@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler 77.24% (-0.46%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus 18.18% (-0.97%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/schedulingshard_types.go 0.00% (ø) 5 0 5
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/zz_generated.deepcopy.go 0.00% (ø) 265 (+7) 0 265 (+7)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_for_shard.go 86.54% (-1.22%) 104 (+6) 90 (+4) 14 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go 18.18% (-0.97%) 99 (+5) 18 81 (+5) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_test.go

Copy link
Collaborator

@enoodle enoodle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this PR should be split in 2 with one updating the docs and the other the code in pkg/

@itsomri itsomri force-pushed the omric/add-time-aware-docs branch 4 times, most recently from 587116c to ae5ea34 Compare November 13, 2025 12:37
@itsomri itsomri enabled auto-merge (squash) November 13, 2025 12:39
@itsomri itsomri force-pushed the omric/add-time-aware-docs branch from c2bc3cd to 5307efb Compare November 13, 2025 12:59
@itsomri itsomri force-pushed the omric/add-time-aware-docs branch from 5307efb to 8a3e592 Compare November 16, 2025 11:37
@itsomri itsomri force-pushed the omric/add-time-aware-docs branch from 8a3e592 to 39b5628 Compare November 17, 2025 13:52
@itsomri itsomri merged commit 2492508 into main Nov 17, 2025
4 checks passed
@itsomri itsomri deleted the omric/add-time-aware-docs branch November 17, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants