Skip to content

fix(operator): Restrict webhook and CRD permissions with resourceNames #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 18, 2025
Merged

fix(operator): Restrict webhook and CRD permissions with resourceNames #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
800e4da
fix(operator): Add resource names for webhook configurations and CRDs
lokielse Nov 12, 2025
36853fa
split the get/list/watch ones from the create/delete/update ones
lokielse Nov 12, 2025
f8ad565
fix(operator): update resource names for webhook configuration in ope…
lokielse Nov 12, 2025
05eaa75
Merge branch 'main' into restrict-webhook-config-resource-names
enoodle Nov 12, 2025
2ffc3cd
fix(operator): update resource names and verbs for webhook configurat…
lokielse Nov 13, 2025
48c5a23
Merge branch 'main' into restrict-webhook-config-resource-names
enoodle Nov 13, 2025
b55d7c6
Merge branch 'main' into restrict-webhook-config-resource-names
lokielse Nov 14, 2025
c6f549e
fix(operator): update webhook configuration resource names in operato…
lokielse Nov 14, 2025
c89b01e
Merge branch 'main' into restrict-webhook-config-resource-names
lokielse Nov 14, 2025
ffe51c4
Merge branch 'main' into restrict-webhook-config-resource-names
lokielse Nov 16, 2025
1de133c
fix(operator): update RBAC permissions for webhook configurations and…
lokielse Nov 16, 2025
e8b8734
Merge branch 'main' into restrict-webhook-config-resource-names
enoodle Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions deployments/kai-scheduler/templates/rbac/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,24 +43,42 @@ rules:
- validatingwebhookconfigurations
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- admissionregistration.k8s.io
resourceNames:
- kai-podgroup-validation-v2alpha2
- kai-queue-validation-v2
- mutating-kai-admission
- validating-kai-admission
resources:
- mutatingwebhookconfigurations
- validatingwebhookconfigurations
verbs:
- delete
- patch
- update
- watch
- apiGroups:
- apiextensions.k8s.io
resources:
- customresourcedefinitions
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- apiextensions.k8s.io
resourceNames:
- queues.scheduling.run.ai
resources:
- customresourcedefinitions
verbs:
- delete
- patch
- update
- watch
- apiGroups:
- apps
resources:
Expand Down
7 changes: 4 additions & 3 deletions pkg/operator/controller/config_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ func (r *ConfigReconciler) SetOperands(ops []operands.Operand) {
// +kubebuilder:rbac:groups=apps,resources=deployments;daemonsets,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="",resources=nodes,verbs=get;list;watch
// +kubebuilder:rbac:groups="",resources=services;secrets;serviceaccounts;configmaps;persistentvolumeclaims;pods;endpoints,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="admissionregistration.k8s.io",resources=mutatingwebhookconfigurations;validatingwebhookconfigurations,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="apiextensions.k8s.io",resources=customresourcedefinitions,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="apiextensions.k8s.io",resources=customresourcedefinitions,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="admissionregistration.k8s.io",resources=mutatingwebhookconfigurations;validatingwebhookconfigurations,resourceNames=kai-podgroup-validation-v2alpha2;kai-queue-validation-v2;mutating-kai-admission;validating-kai-admission,verbs=delete;update;patch
// +kubebuilder:rbac:groups="admissionregistration.k8s.io",resources=mutatingwebhookconfigurations;validatingwebhookconfigurations,verbs=get;list;watch;create
// +kubebuilder:rbac:groups="apiextensions.k8s.io",resources=customresourcedefinitions,resourceNames=queues.scheduling.run.ai,verbs=delete;update;patch
// +kubebuilder:rbac:groups="apiextensions.k8s.io",resources=customresourcedefinitions,verbs=get;list;watch;create
// +kubebuilder:rbac:groups="nvidia.com",resources=clusterpolicies,verbs=get;list;watch
// +kubebuilder:rbac:groups="monitoring.coreos.com",resources=prometheuses;servicemonitors,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="scheduling.run.ai",resources=queues,verbs=get;list;watch
Expand Down
Loading