Skip to content

Conversation

@enoodle
Copy link
Collaborator

@enoodle enoodle commented Nov 11, 2025

Description

Fixes a problem of high CPU usage of the operator pod in Openshift due to repeatedly removing an image pull secret that openshift wants to add to the reservation pods service account

Related Issues

Fixes #

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated CHANGELOG.md (if needed)
  • Updated documentation (if needed)

Breaking Changes

Additional Notes

@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder 68.18% (-1.43%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder/resources.go 67.39% (-1.66%) 92 (+8) 62 (+4) 30 (+4) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

itsomri
itsomri previously approved these changes Nov 12, 2025
@enoodle enoodle force-pushed the erez/fix-openshift-operator-sa-reconcile branch from 14e8c46 to b4a07b4 Compare November 12, 2025 08:38
@enoodle enoodle enabled auto-merge (squash) November 12, 2025 08:41
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder 75.68% (+9.01%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder/resources.go 77.17% (+10.88%) 92 (+3) 71 (+12) 21 (-9) 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder/binder_test.go

@enoodle enoodle merged commit 2259f01 into main Nov 12, 2025
4 checks passed
@enoodle enoodle deleted the erez/fix-openshift-operator-sa-reconcile branch November 12, 2025 09:48
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder 73.28% (+6.61%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder/resources.go 74.23% (+7.93%) 97 (+8) 72 (+13) 25 (-5) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/binder/binder_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants