Skip to content

Conversation

@itsomri
Copy link
Collaborator

@itsomri itsomri commented Nov 11, 2025

Description

This PR lets the user enable time aware scheduling by configuring the scheduling shard

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated CHANGELOG.md (if needed)
  • Updated documentation (if needed)

Breaking Changes

N/A

Additional Notes

N/A

@itsomri itsomri force-pushed the omric/add-time-aware-configs-shard branch 2 times, most recently from 1d80fdb to f087f05 Compare November 11, 2025 16:18
@github-actions
Copy link

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/common 52.25% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/known_types 13.06% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus 51.75% (+0.64%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler 78.32% (-0.51%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus 18.18% (-0.97%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/schedulingshard_types.go 0.00% (ø) 5 0 5
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/zz_generated.deepcopy.go 0.00% (ø) 265 (+7) 0 265 (+7)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/common/common.go 52.25% (ø) 111 58 53
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/known_types/prometheus.go 5.19% (ø) 77 4 73
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus/resources.go 83.62% (+0.43%) 116 (+3) 97 (+3) 19 👍
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_for_shard.go 86.54% (-1.22%) 104 (+6) 90 (+4) 14 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go 18.18% (-0.97%) 99 (+5) 18 81 (+5) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus/prometheus_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_test.go

@itsomri itsomri force-pushed the omric/add-time-aware-configs-shard branch from f087f05 to f5bc7df Compare November 11, 2025 17:43
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler 78.32% (-0.51%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus 18.18% (-0.97%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/schedulingshard_types.go 0.00% (ø) 5 0 5
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/zz_generated.deepcopy.go 0.00% (ø) 265 (+7) 0 265 (+7)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_for_shard.go 86.54% (-1.22%) 104 (+6) 90 (+4) 14 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go 18.18% (-0.97%) 99 (+5) 18 81 (+5) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_test.go

@itsomri itsomri force-pushed the omric/add-time-aware-configs-shard branch from f5bc7df to 12af1dd Compare November 12, 2025 07:55
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler 77.24% (-0.46%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus 18.18% (-0.97%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/schedulingshard_types.go 0.00% (ø) 5 0 5
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/zz_generated.deepcopy.go 0.00% (ø) 265 (+7) 0 265 (+7)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_for_shard.go 86.54% (-1.22%) 104 (+6) 90 (+4) 14 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go 18.18% (-0.97%) 99 (+5) 18 81 (+5) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_test.go

@itsomri itsomri force-pushed the omric/add-time-aware-configs-shard branch from c278c8f to 0356a69 Compare November 12, 2025 19:31
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/common 52.25% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus 52.30% (+0.81%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler 79.14% (+1.44%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api 29.85% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus 18.18% (-0.97%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/global.go 0.00% (ø) 25 0 25
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/schedulingshard_types.go 0.00% (ø) 5 0 5
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/zz_generated.deepcopy.go 0.00% (ø) 261 (+3) 0 261 (+3)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/common/common.go 52.25% (ø) 111 58 53
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus/resources.go 83.62% (+0.58%) 116 (+4) 97 (+4) 19 👍
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_for_shard.go 87.70% (-0.05%) 122 (+24) 107 (+21) 15 (+3) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go 13.51% (ø) 37 5 32
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go 18.18% (-0.97%) 99 (+5) 18 81 (+5) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_test.go

@itsomri itsomri force-pushed the omric/add-time-aware-configs-shard branch from 0356a69 to 07ebd7d Compare November 12, 2025 20:37
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/common 52.25% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus 52.30% (+0.81%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler 79.14% (+1.44%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api 29.85% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus 18.18% (-0.97%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/global.go 0.00% (ø) 25 0 25
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/schedulingshard_types.go 0.00% (ø) 5 0 5
github.com/NVIDIA/KAI-scheduler/pkg/apis/kai/v1/zz_generated.deepcopy.go 0.00% (ø) 261 (+3) 0 261 (+3)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/common/common.go 52.25% (ø) 111 58 53
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus/resources.go 83.62% (+0.58%) 116 (+4) 97 (+4) 19 👍
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_for_shard.go 87.70% (-0.05%) 122 (+24) 107 (+21) 15 (+3) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go 13.51% (ø) 37 5 32
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go 18.18% (-0.97%) 99 (+5) 18 81 (+5) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/scheduler/resources_test.go

@itsomri itsomri merged commit ae2d6b3 into main Nov 13, 2025
4 checks passed
@itsomri itsomri deleted the omric/add-time-aware-configs-shard branch November 13, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants