Skip to content

Conversation

@itsomri
Copy link
Collaborator

@itsomri itsomri commented Nov 11, 2025

Description

This PR fixes the prometheus operand for time aware fairness:

  • Fixes queue-controller service monitor name
  • Adds missing accounting: kai label
  • Adds kube-state-metrics service monitor

Checklist

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated CHANGELOG.md (if needed)
  • Updated documentation (if needed)

Breaking Changes

N/A

Additional Notes

N/A

@itsomri itsomri force-pushed the omric/fix-prometheus-operand branch from cb537ff to e03b6b3 Compare November 11, 2025 15:51
@itsomri itsomri force-pushed the omric/fix-prometheus-operand branch from e03b6b3 to e73836e Compare November 11, 2025 16:17
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/common 52.25% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/known_types 13.06% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus 51.75% (+0.64%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/common/common.go 52.25% (ø) 111 58 53
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/known_types/prometheus.go 5.19% (ø) 77 4 73
github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus/resources.go 83.62% (+0.43%) 116 (+3) 97 (+3) 19 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/operator/operands/prometheus/prometheus_test.go

@itsomri itsomri merged commit 62e2e1c into main Nov 11, 2025
4 checks passed
@itsomri itsomri deleted the omric/fix-prometheus-operand branch November 11, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants