Skip to content

Conversation

@davidLif
Copy link
Collaborator

Description

1- Publish the pod-grouper DefaultPluginsHub as a DefaultPluginsHub object instead of a PluginsHub interface

2- Allow the DefaultPluginsHub to publish it's default plugin and a HasMatchingPlugin function

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • [V] Self-reviewed
  • [V] Added/updated tests (if needed)
  • [V] Updated CHANGELOG.md (if needed)
  • [ V] Updated documentation (if needed)

@davidLif davidLif enabled auto-merge (squash) November 11, 2025 12:23
@davidLif davidLif changed the title feat(pod-grouper): Publish the pod-grouper DefaultPluginsHub feat(podgrouper): Publish the pod-grouper DefaultPluginsHub Nov 11, 2025
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 82.14% (-17.86%) 💀

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app/app.go 0.00% (ø) 48 0 48
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 82.14% (-17.86%) 28 (+5) 23 5 (+5) 💀

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@davidLif davidLif force-pushed the DavidL/33282/podGrouperPublishDefaultPluginHub branch from 4a562ac to 1f00c58 Compare November 11, 2025 13:34
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 82.14% (-17.86%) 💀

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app/app.go 0.00% (ø) 48 0 48
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 82.14% (-17.86%) 28 (+5) 23 5 (+5) 💀

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@davidLif davidLif force-pushed the DavidL/33282/podGrouperPublishDefaultPluginHub branch from 1f00c58 to c7d8140 Compare November 11, 2025 16:39
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 82.14% (-17.86%) 💀

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app/app.go 0.00% (ø) 48 0 48
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 82.14% (-17.86%) 28 (+5) 23 5 (+5) 💀

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@davidLif davidLif force-pushed the DavidL/33282/podGrouperPublishDefaultPluginHub branch from c7d8140 to 8f98b44 Compare November 11, 2025 17:51
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 82.14% (-17.86%) 💀

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app/app.go 0.00% (ø) 48 0 48
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 82.14% (-17.86%) 28 (+5) 23 5 (+5) 💀

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@davidLif davidLif force-pushed the DavidL/33282/podGrouperPublishDefaultPluginHub branch from 8f98b44 to 5bde13a Compare November 12, 2025 08:00
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 82.14% (-17.86%) 💀

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app/app.go 0.00% (ø) 48 0 48
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 82.14% (-17.86%) 28 (+5) 23 5 (+5) 💀

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@davidLif davidLif force-pushed the DavidL/33282/podGrouperPublishDefaultPluginHub branch from 5bde13a to a59c60b Compare November 12, 2025 11:06
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 82.14% (-17.86%) 💀

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app/app.go 0.00% (ø) 48 0 48
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 82.14% (-17.86%) 28 (+5) 23 5 (+5) 💀

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

…bject instead of a PluginsHub interface

2- Allow the DefaultPluginsHub to publish it's default plugin and a HasMatchingPlugin function
@davidLif davidLif force-pushed the DavidL/33282/podGrouperPublishDefaultPluginHub branch from a59c60b to d04a35b Compare November 13, 2025 10:08
@davidLif davidLif merged commit d65607a into main Nov 13, 2025
4 checks passed
@davidLif davidLif deleted the DavidL/33282/podGrouperPublishDefaultPluginHub branch November 13, 2025 10:39
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub 82.14% (-17.86%) 💀

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgrouper/app/app.go 0.00% (ø) 48 0 48
github.com/NVIDIA/KAI-scheduler/pkg/podgrouper/podgrouper/hub/hub.go 82.14% (-17.86%) 28 (+5) 23 5 (+5) 💀

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants