Skip to content

Conversation

@enoodle
Copy link
Collaborator

@enoodle enoodle commented Aug 30, 2025

No description provided.

SiorMeir
SiorMeir previously approved these changes Aug 31, 2025
@enoodle enoodle force-pushed the erez/remove-unused-binder-arg-and-volume branch from 86051e9 to 77abef0 Compare August 31, 2025 08:06
@github-actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/cmd/binder 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/binder/app 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding 75.93% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/binder/controllers/integration_tests 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/binder/plugins/gpusharing 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/cmd/binder/app/app.go 0.00% (ø) 70 (-6) 0 70 (-6)
github.com/NVIDIA/KAI-scheduler/cmd/binder/app/options.go 0.00% (ø) 22 (-2) 0 22 (-2)
github.com/NVIDIA/KAI-scheduler/cmd/binder/main.go 0.00% (ø) 21 0 21
github.com/NVIDIA/KAI-scheduler/pkg/binder/plugins/gpusharing/gpu_sharing.go 0.00% (ø) 30 0 30

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/default_binder_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/fraction_binder_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/binder/controllers/integration_tests/suite_test.go

@enoodle enoodle enabled auto-merge (squash) August 31, 2025 08:43
@enoodle enoodle merged commit 0af7960 into main Aug 31, 2025
4 checks passed
@enoodle enoodle deleted the erez/remove-unused-binder-arg-and-volume branch August 31, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants