move crds into helm chart #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enoodle
force-pushed
the
erez/move-crds-into-chart
branch
from
4e61d79 to
6133adf
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged unit test files
|
SiorMeir
previously approved these changes
Aug 31, 2025
enoodle
force-pushed
the
erez/move-crds-into-chart
branch
from
6133adf to
abfa66e
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged unit test files
|
enoodle
force-pushed
the
erez/move-crds-into-chart
branch
from
abfa66e to
b190db1
Compare
enoodle
force-pushed
the
erez/move-crds-into-chart
branch
from
b190db1 to
4271746
Compare
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged unit test files
|
romanbaron
reviewed
Sep 2, 2025
enoodle
force-pushed
the
erez/move-crds-into-chart
branch
from
4271746 to
3eb0f4a
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged unit test files
|
romanbaron
previously approved these changes
Sep 2, 2025
romanbaron
approved these changes
Sep 2, 2025
Merging this branch will not change overall coverage
Coverage by fileChanged unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify creating objects from those CRDs by the helm chart, we will add them to the chart which means that they will be created when the chart is first installed.
The crd-upgrader will still run to upgrade the CRDs .