Skip to content

Conversation

@omer-dayan
Copy link
Collaborator

No description provided.

@omer-dayan omer-dayan changed the title [WIP] Refactor subg rem Not using summerized MinAvailable for PodGroup, but look per SubGroup Aug 26, 2025
Base automatically changed from refactor-subg-3 to main August 28, 2025 11:36
@omer-dayan omer-dayan force-pushed the refactor-subg-rem branch 2 times, most recently from d94de63 to f705e78 Compare August 28, 2025 11:53
@omer-dayan omer-dayan force-pushed the refactor-subg-rem branch 2 times, most recently from 85e38f6 to 7967b96 Compare August 28, 2025 19:19
romanbaron
romanbaron previously approved these changes Aug 28, 2025
@omer-dayan omer-dayan enabled auto-merge (squash) August 29, 2025 14:13
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 3 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 61.39% (-0.56%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/elastic 91.67% (+4.17%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/minruntime 75.27% (+0.86%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion 37.44% (+2.94%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/job_info.go 35.24% (-0.68%) 210 (+4) 74 136 (+4) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/subgroup_info.go 100.00% (ø) 45 (+1) 45 (+1) 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/elastic/elastic.go 91.67% (+4.17%) 24 (+8) 22 (+8) 2 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/minruntime/minruntime.go 62.96% (+2.76%) 108 (+10) 68 (+9) 40 (+1) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/proportion.go 37.44% (+2.94%) 211 (+11) 79 (+10) 132 (+1) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/subgroup_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/elastic/elastic_test.go

@omer-dayan omer-dayan merged commit fa7b160 into main Aug 31, 2025
4 checks passed
@omer-dayan omer-dayan deleted the refactor-subg-rem branch August 31, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants