Time aware fairness usage: prometheus client #435

itsomri · 2025-08-25T12:21:09Z

This PR introduces a prometheus client to be used for queue resource tracking.
Important notes:

Adds a docs/metrics directory with the required setup
Adds an ExtraParams for plugin-specific configurations (such as prometheus query resolution)
Observe query latency metric

github-actions · 2025-08-25T14:27:49Z

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	57.65% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	55.88% (-44.12%)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	18.18% (+18.18%)	🎉

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	55.88% (-44.12%)	34 (+15)	19	15 (+15)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	18.18% (+18.18%)	55 (+55)	10 (+10)	45 (+45)	🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go

github-actions · 2025-08-25T15:55:49Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (-0.67%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	55.88% (-44.12%)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	18.18% (+18.18%)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	55.88% (-44.12%)	34 (+15)	19	15 (+15)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	18.18% (+18.18%)	55 (+55)	10 (+10)	45 (+45)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb.go	37.29% (-0.64%)	59 (+1)	22	37 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics/metrics.go	0.00% (ø)	51 (+2)	0	51 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go

github-actions · 2025-08-26T08:18:46Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (-0.67%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	55.88% (-44.12%)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	18.18% (+18.18%)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	55.88% (-44.12%)	34 (+15)	19	15 (+15)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	18.18% (+18.18%)	55 (+55)	10 (+10)	45 (+45)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb.go	37.29% (-0.64%)	59 (+1)	22	37 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics/metrics.go	0.00% (ø)	51 (+2)	0	51 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go

github-actions · 2025-08-26T14:45:35Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (-0.67%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	55.88% (-44.12%)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	18.18% (+18.18%)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	55.88% (-44.12%)	34 (+15)	19	15 (+15)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	18.18% (+18.18%)	55 (+55)	10 (+10)	45 (+45)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb.go	37.29% (-0.64%)	59 (+1)	22	37 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics/metrics.go	0.00% (ø)	51 (+2)	0	51 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go

github-actions · 2025-08-27T08:43:33Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (-0.67%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	55.88% (-44.12%)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	18.18% (+18.18%)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/defaults.go	48.28% (+48.28%)	29 (+29)	14 (+14)	15 (+15)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	100.00% (ø)	5 (-14)	5 (-14)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	18.18% (+18.18%)	55 (+55)	10 (+10)	45 (+45)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb.go	37.29% (-0.64%)	59 (+1)	22	37 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics/metrics.go	0.00% (ø)	51 (+2)	0	51 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go

github-actions · 2025-08-27T12:20:19Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (-0.67%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	55.88% (-44.12%)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	18.18% (+18.18%)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/defaults.go	48.28% (+48.28%)	29 (+29)	14 (+14)	15 (+15)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	100.00% (ø)	5 (-14)	5 (-14)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	18.18% (+18.18%)	55 (+55)	10 (+10)	45 (+45)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb.go	37.29% (-0.64%)	59 (+1)	22	37 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics/metrics.go	0.00% (ø)	51 (+2)	0	51 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go

github-actions · 2025-08-27T13:13:38Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (-0.67%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	55.88% (-44.12%)	💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	18.18% (+18.18%)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/defaults.go	48.28% (+48.28%)	29 (+29)	14 (+14)	15 (+15)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	100.00% (ø)	5 (-14)	5 (-14)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	18.18% (+18.18%)	55 (+55)	10 (+10)	45 (+45)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb.go	37.29% (-0.64%)	59 (+1)	22	37 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics/metrics.go	0.00% (ø)	51 (+2)	0	51 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go

pkg/scheduler/cache/usagedb/api/defaults.go

pkg/scheduler/cache/usagedb/prometheus/prometheus.go

github-actions · 2025-08-28T08:45:48Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/queue_info	66.67% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	83.94% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (-0.67%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	50.00% (-50.00%)	💀 💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	18.18% (+18.18%)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion	34.50% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/resource_share	70.71% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/queue_info/quota_info.go	0.00% (ø)	1	0	1
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/defaults.go	40.00% (+40.00%)	25 (+25)	10 (+10)	15 (+15)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	100.00% (ø)	5 (-14)	5 (-14)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	18.18% (+18.18%)	55 (+55)	10 (+10)	45 (+45)	🎉
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb.go	37.29% (-0.64%)	59 (+1)	22	37 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics/metrics.go	0.00% (ø)	51 (+2)	0	51 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/proportion.go	34.50% (ø)	200	69	131
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/resource_share/queue_resource_share.go	92.31% (ø)	65	60	5

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/usage_params_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb_test.go

github-actions · 2025-08-28T09:17:32Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/queue_info	66.67% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	83.94% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (-0.67%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	50.00% (-50.00%)	💀 💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	23.81% (+23.81%)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion	34.50% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/resource_share	70.71% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/queue_info/quota_info.go	0.00% (ø)	1	0	1
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/defaults.go	40.00% (+40.00%)	25 (+25)	10 (+10)	15 (+15)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	100.00% (ø)	5 (-14)	5 (-14)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	23.81% (+23.81%)	42 (+42)	10 (+10)	32 (+32)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb.go	37.29% (-0.64%)	59 (+1)	22	37 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics/metrics.go	0.00% (ø)	51 (+2)	0	51 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/proportion.go	34.50% (ø)	200	69	131
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/resource_share/queue_resource_share.go	92.31% (ø)	65	60	5

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/usage_params_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb_test.go

github-actions · 2025-08-28T12:13:37Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/queue_info	66.67% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	83.94% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (-0.67%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api	50.00% (-50.00%)	💀 💀 💀 💀 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus	23.81% (+23.81%)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion	34.50% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/resource_share	70.71% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/queue_info/quota_info.go	0.00% (ø)	1	0	1
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/defaults.go	40.00% (+40.00%)	25 (+25)	10 (+10)	15 (+15)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/interface.go	100.00% (ø)	5 (-14)	5 (-14)	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus.go	23.81% (+23.81%)	42 (+42)	10 (+10)	32 (+32)	🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb.go	37.29% (-0.64%)	59 (+1)	22	37 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/metrics/metrics.go	0.00% (ø)	51 (+2)	0	51 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/proportion.go	34.50% (ø)	200	69	131
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/resource_share/queue_resource_share.go	92.31% (ø)	65	60	5

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/api/usage_params_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/prometheus/prometheus_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/usagedb_test.go

itsomri force-pushed the omric/time-aware-fairness-usage-prometheus branch 2 times, most recently from 98a5cd7 to 9f169e4 Compare August 25, 2025 14:02

itsomri force-pushed the omric/time-aware-fairness-usage-prometheus branch from 9f169e4 to 3366136 Compare August 25, 2025 15:30

itsomri force-pushed the omric/time-aware-fairness-usage-prometheus branch from 3366136 to 865764c Compare August 26, 2025 07:53

itsomri force-pushed the omric/time-aware-fairness-usage-prometheus branch from 865764c to e16e57f Compare August 26, 2025 14:19

itsomri force-pushed the omric/time-aware-fairness-usage-prometheus branch from e16e57f to 5bca1b2 Compare August 27, 2025 08:17

itsomri force-pushed the omric/time-aware-fairness-usage-prometheus branch from 64b7cf9 to 0c6d9e7 Compare August 27, 2025 12:48

enoodle reviewed Aug 27, 2025

View reviewed changes

pkg/scheduler/cache/usagedb/api/defaults.go Show resolved Hide resolved

pkg/scheduler/cache/usagedb/prometheus/prometheus.go Show resolved Hide resolved

enoodle approved these changes Aug 28, 2025

View reviewed changes

itsomri added 12 commits August 28, 2025 14:48

WIP prometheus

a93e5d1

Disable default db config

10a5494

Remove capacity

e4a90d8

Added prometheus to plugins

a22ecd9

CR Prep

b21a792

Added copyright headers

02bdc21

Add query latency metric

30d1894

Move defaults to a separate file

5dc1ac9

Renamed service monitor

98af884

Renamed metrics

030e171

Fixed query injection

fd2fa12

Removed GetWindowTypeOrDefault

f2f0ab1

itsomri added 2 commits August 28, 2025 14:48

made QueueUsage a map

248086e

Change implementation to for loop

da2ba41

itsomri force-pushed the omric/time-aware-fairness-usage-prometheus branch from 0a1ef85 to da2ba41 Compare August 28, 2025 11:48

itsomri enabled auto-merge (squash) August 28, 2025 11:49

itsomri merged commit 847bc71 into main Aug 28, 2025
4 checks passed

itsomri deleted the omric/time-aware-fairness-usage-prometheus branch August 28, 2025 12:13

Time aware fairness usage: prometheus client #435

Time aware fairness usage: prometheus client #435

Uh oh!

Conversation

itsomri commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 25, 2025

Merging this branch changes the coverage (1 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Aug 25, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Aug 26, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Aug 26, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Aug 27, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Aug 27, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Aug 27, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 28, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Aug 28, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

Uh oh!

github-actions bot commented Aug 28, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

itsomri commented Aug 25, 2025 •

edited

Loading