v0.4 - cherry pick mig and memory fixes #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: GPU memory calculation using incorrect unit conversion Fixes #416 The GPU memory validation was incorrectly converting MiB to MB and back, causing the scheduler to use inflated memory values (48300 MB instead of 46068 MiB) when checking shared GPU allocations. This allowed pods to be scheduled beyond the actual GPU memory capacity. Changes: - Use original MiB value from nvidia.com/gpu.memory node label directly - Remove unnecessary MiB->MB->MiB conversion that caused precision loss - Maintain the flooring logic for memory alignment but in MiB units * Remove unused convertMibToMb function and explanatory comments * Remove unused resource import after convertMibToMb cleanup 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * test: update GPU memory unit conversion test expectations Fix test expectations after removing MiB to MB conversion. Tests now correctly expect 4000 MiB instead of 4200 MB. Fixes #416 * Format code with go fmt --------- Co-authored-by: Ngô Quang Hòa <[email protected]> Co-authored-by: Claude <[email protected]>
* fix mig scheduling issue * clean up the code --------- Co-authored-by: bmao <[email protected]>
enoodle
force-pushed
the
erez/v0.4/cherry-pick-mig-and-momory-fixes
branch
from
d9f78f2 to
47df9b7
Compare
itsomri
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.