Skip to content

Conversation

@romanbaron
Copy link
Collaborator

No description provided.

@romanbaron romanbaron force-pushed the roman/subgroup-pod-status-cache branch from 09784d4 to 40c65b0 Compare August 24, 2025 18:20
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/common 32.10% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils 46.72% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 67.86% (+0.50%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/status_updater 79.41% (+0.98%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/reclaimable 92.92% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 81.39% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/subgroup_info.go 100.00% (ø) 44 (+6) 44 (+6) 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/common/feasible_nodes_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils/job_order_by_queue_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/job_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/subgroup_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/status_updater/default_status_updater_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/reclaimable/reclaimable_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin_job_filtering_test.go

@romanbaron romanbaron enabled auto-merge (squash) August 25, 2025 06:55
@romanbaron romanbaron force-pushed the roman/subgroup-pod-status-cache branch from 40c65b0 to 05d60a1 Compare August 26, 2025 18:03
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/common 32.10% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils 46.72% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 67.86% (+0.50%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/status_updater 78.76% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/reclaimable 92.92% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 81.39% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/subgroup_info.go 100.00% (ø) 44 (+6) 44 (+6) 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/common/feasible_nodes_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils/job_order_by_queue_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/job_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/subgroup_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/status_updater/default_status_updater_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/reclaimable/reclaimable_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin_job_filtering_test.go

@romanbaron romanbaron merged commit 8c57466 into main Aug 27, 2025
4 checks passed
@romanbaron romanbaron deleted the roman/subgroup-pod-status-cache branch August 27, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants