Skip to content

Conversation

@davidLif
Copy link
Collaborator

No description provided.

@davidLif davidLif force-pushed the DavidL/29102/e2eTests branch from 49feb38 to 52df200 Compare August 26, 2025 08:08
@github-actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/configurations/feature_flags 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/node_order 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/topology 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/configurations/feature_flags/placement_strategy.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/topology.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/node_order/placement_strategy_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/topology/topology_suite_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/topology/topology_test.go

Copy link
Collaborator

@SiorMeir SiorMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
left 2 comments but these are non-blocking.

@davidLif davidLif enabled auto-merge (squash) August 26, 2025 13:54
@davidLif davidLif merged commit 26a70ec into main Aug 26, 2025
4 checks passed
@davidLif davidLif deleted the DavidL/29102/e2eTests branch August 26, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants