Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing nsys-jax. The profiler had an issue in data loader, when profiling NCCL operations, in
_load_nvtx_gpu_proj_trace_singlewhen trying to link thunks to their parent XLA modules.Investigation of the input profiles revealed an unexpected hierarchy structure. The original code assumed the NVTX range hierarchy would contain only:
However, NCCL collective operations inject intermediate ranges into the hierarchy:
The code's assertion
assert (mask == mod_id_names.str.startswith(thunk_prefix)).all()failed because it assumed any non-module parent must be a thunk, but NCCL ranges like ncclGroupEnd are neither modules nor thunks.Here I've changed: