jax-toolbox-triage: minor usability/doc improvements #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Print the stdout/stderr of the first execution of the test case, which is supposed to fail, at INFO level along with a message encouraging the user to check that it is the correct failure. - Print the path to the DEBUG log file at INFO level and, therefore, to the console. - Expand the documentation.
olupton
force-pushed
the
olupton/triage-tweaks
branch
from
1e95fa5 to
3ad9cc2
Compare
olupton
force-pushed
the
olupton/triage-tweaks
branch
from
54a1772 to
ee796e4
Compare
These allow the container-level search to be skipped entirely, which enables bisecting at the commit level on containers not from the ghcr.io/nvidia/jax:CONTAINER-YYYY-MM-DD series.
olupton
force-pushed
the
olupton/triage-tweaks
branch
from
ee796e4 to
0fb73cc
Compare
nouiz
reviewed
Oct 29, 2024
nouiz
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--passing-containerand--failing-containerarguments, which allow the container-level search to be skipped and non-dated containers to be triaged.