Skip to content

Conversation

@gpupuck
Copy link
Contributor

@gpupuck gpupuck commented Oct 15, 2024

This would allow

-a "scan_layers=false max_target_length=4096 use_iota_embed=true logits_dot_in_fp32=false"

to be

-a scan_layers=false 
-a max_target_length=4096 
-a use_iota_embed=true 
-a logits_dot_in_fp32=false

It will help avoid issues if quotes are not present during string interpolation.

@gpupuck gpupuck requested a review from kocchop October 15, 2024 17:22
@kocchop
Copy link
Contributor

kocchop commented Oct 15, 2024

@gpupuck all the maxtext CI tests are failing

@kocchop kocchop merged commit ddec4bd into main Oct 16, 2024
163 of 174 checks passed
@kocchop kocchop deleted the by/many-additional-args branch October 16, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants