-
Notifications
You must be signed in to change notification settings - Fork 17
refactor(customization): accum every training metric as time series #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
albcui
wants to merge
23
commits into
main
Choose a base branch
from
albcui/aalgo-497-training-progress-infra
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
73750b1
refactor(rl): use the shared training progress callback directly
albcui d94bc20
fix(customization): stop non-step reports from erasing the metric series
albcui 3148e23
feat(customization): accumulate a time series for every reported metric
albcui 87dd591
fix(customization): carry sticky status_details fields across updates
albcui 5198b65
fix(rl): report the final training step, and stop double-counting it
albcui db49abd
thanks CodeRabbit
albcui 8c1f86c
refactor(customization): drop the carry-forward machinery
albcui a38f103
fix(customization): correct three defects in the reported payload
albcui 6cb5a18
chore(rl): give the new progress module the header its siblings use
albcui 9e66baa
docs(customization): stop justifying the design with an unwired GRPO …
albcui 8fdf28f
fix(rl): make the steps_per_epoch fallback reachable, and drop a stri…
albcui 3668407
docs(customization): keep the callback's rationale out of the reporter
albcui e72b354
refactor(rl): stop holding a reference the logger never reads
albcui 73fb71e
refactor(customization)!: one naming rule for every training metric
albcui 316a082
docs(customizer): document the metric naming rule and the series payload
albcui 58307cc
fix(rl): bound progress reports by run length, not just val_period
albcui 2889bf6
fix(automodel): strip the val_ prefix the recipes already applied
albcui 934d8b1
fix(customization): discard the steps a resumed run replays
albcui 4095302
fix(rl): report a validation pass that scores on something other than…
albcui a27cd5a
fix(customization): correct twelve defects across the progress report…
albcui f21d67e
fix(rl): derive the train report cadence from run length alone
albcui 5d86886
update docstrings to reflect seeding mechanism
albcui 25f30ae
refactor(customization): rename the metric-name qualifier off "namesp…
albcui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is backend the right word here? DPO and GRPO are same backend, do they report the same metrics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The infrastructure for logging metrics is at the backend level. DPO and GRPO share the same logger, just different metrics. Previously, we were being opinionated about which metrics to report, now I'm just going to report all numeric metrics given to us. Maybe we should have an allowlist, but we can add that later. This means, once this change lands, we should more or less get GRPO metrics for free.