-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Use Partial Prefix to Prompt Time Series Generation #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seayang-nv
wants to merge
6
commits into
main
Choose a base branch
from
seayang/partial-record-prefix-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
972e065
prefix prompt generation
417ea1c
refined implementation
seayang-nv c99b613
addressed rabbit
seayang-nv 1195a18
addressed rabbit comments on testing
seayang-nv 8ae38b0
fixed typecheck error
seayang-nv 98d49c5
fix: address time-series prefix review feedback
seayang-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
src/nemo_safe_synthesizer/data_processing/prompt_tokens.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Shared prompt and sequence token-boundary assembly.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from collections.abc import Sequence | ||
| from typing import TYPE_CHECKING, Protocol | ||
|
|
||
| if TYPE_CHECKING: | ||
| from ..llm.metadata import LLMPromptConfig | ||
|
|
||
| __all__ = [ | ||
| "EncodeOnlyTokenizer", | ||
| "encode_prompt_token_ids", | ||
| "wrap_sequence_token_ids", | ||
| ] | ||
|
|
||
|
|
||
| class EncodeOnlyTokenizer(Protocol): | ||
| """Tokenizer interface required for prompt construction.""" | ||
|
|
||
| def encode(self, text: str, *, add_special_tokens: bool) -> list[int]: | ||
| """Encode text while explicitly controlling tokenizer special tokens.""" | ||
|
|
||
|
|
||
| def encode_prompt_token_ids( | ||
| prompt: str, | ||
| *, | ||
| tokenizer: EncodeOnlyTokenizer, | ||
| prompt_config: LLMPromptConfig, | ||
| ) -> list[int]: | ||
| """Encode a prompt with its configured BOS and EOS boundaries.""" | ||
| prompt_ids = list(tokenizer.encode(prompt, add_special_tokens=False)) | ||
| if prompt_config.add_bos_token_to_prompt: | ||
| prompt_ids.insert(0, prompt_config.bos_token_id) | ||
| if prompt_config.add_eos_token_to_prompt: | ||
| prompt_ids.append(prompt_config.eos_token_id) | ||
| return prompt_ids | ||
|
|
||
|
|
||
| def wrap_sequence_token_ids( | ||
| token_ids: Sequence[int], | ||
| *, | ||
| prompt_config: LLMPromptConfig, | ||
| include_eos: bool, | ||
| ) -> list[int]: | ||
| """Return sequence IDs with a leading BOS and an optional trailing EOS.""" | ||
| sequence_ids = [prompt_config.bos_token_id, *token_ids] | ||
| if include_eos: | ||
| sequence_ids.append(prompt_config.eos_token_id) | ||
| return sequence_ids |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.