chore: drop unreferenced NVIDIA package indexes - #706
Conversation
nv-shared-pypi-local and nvidia-pypi-public have been declared since the initial commit, carried over when the project moved off NVIDIA's internal GitLab and copied verbatim into cuda_deps.toml by #655. Neither is reachable by the resolver. Both are explicit = true, which means uv consults them only for packages that name them in [tool.uv.sources], and no package does. Every nvidia-* package in the lock resolves from PyPI or download.pytorch.org instead. pypi.nvidia.com does still serve wheels during install -- nvidia-cublas-cu12 is resolved from the PyTorch cu129 index, which links to NVIDIA's host rather than rehosting. That download follows the URL recorded in uv.lock and is unaffected by whether the index is declared here. Regenerating and relocking leaves uv.lock byte-identical across all 356 packages, confirming neither index contributed to resolution. Signed-off-by: Yunfeng Zhang <yunzhang@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
WalkthroughThe change removes two explicit CUDA package indexes from ChangesCUDA package index cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryRemoves two unused explicit NVIDIA package indexes from the CUDA dependency source configuration and its generated
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or dependency-resolution issues identified. The removed explicit indexes have no active source bindings, and the authoritative CUDA configuration remains synchronized with the generated project metadata. Important Files Changed
Reviews (1): Last reviewed commit: "chore: drop unreferenced NVIDIA package ..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Removes two
[[indexes]]entries fromcuda_deps.toml(and the regeneratedpyproject.tomlblock) that the resolver cannot reach:nv-shared-pypi-local->https://urm.nvidia.com/artifactory/api/pypi/nv-shared-pypi-local/simplenvidia-pypi-public->https://pypi.nvidia.comBoth have been declared since the initial commit, carried over when the project
moved off NVIDIA's internal GitLab, and copied verbatim into
cuda_deps.tomlby #655.
Why they are inert
Both are
explicit = true, which in uv means the index is consulted only forpackages that name it in
[tool.uv.sources]. No package names either one:Every
nvidia-*package in the lock resolves from PyPI ordownload.pytorch.orginstead.This does not stop pypi.nvidia.com being used
Worth stating explicitly, since it looks contradictory in the lock:
nvidia-cublas-cu12is resolved from the PyTorch cu129 index but its wheels arehosted on
pypi.nvidia.com— PyTorch's index links to NVIDIA's host ratherthan rehosting the artifacts.
That download follows the URL recorded in
uv.lockand is unaffected bywhether the index is declared here.
Verification
Regenerating and relocking leaves
uv.lockbyte-identical across all 356packages — the strongest available evidence that neither index participated in
resolution:
mise run lock-checkpassesmise run format-checkpassespytest tests/test_gen_cuda_deps.py-- 19 passedNotes for reviewers
Two places still mention these names; neither is affected, but flagging so a
grep does not cause confusion:
CONTRIBUTING.md:870documents that the internal NMP service pullsnemo-safe-synthesizerfromnv-shared-pypi-local. That is about how NMPconsumes this package, not how this project resolves its own dependencies, so
it is unaffected.
tests/test_gen_cuda_deps.pyusesnvidia-pypi-publicin inline fixture datato exercise the generator's
index =binding support. The generator stillsupports it; the real config just does not use it. If binding
nvidia-cublasto that index was intended at some point, that would be adeliberate change (re-adding
index = "nvidia-pypi-public"to the cublasentry) rather than a reason to keep an orphaned declaration.
Pre-Review Checklist
mise run format && mise run checkmise run testpasses locally (targeted:tests/test_gen_cuda_deps.py)Other Notes
Config-only change. No dependency versions change and
uv.lockis untouched.Summary by CodeRabbit