feat: add CUDA runtime installation helper - #657
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThe PR adds a runtime installation helper whose CPU and CUDA index sets are generated from the dependency manifest.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the prior platform-specific CPU test and help-handling issues are fixed in the current code. Important Files Changed
|
4127e30 to
7b0ff2e
Compare
552467d to
dceb950
Compare
7b0ff2e to
8629058
Compare
dceb950 to
b53e37e
Compare
| @@ -0,0 +1,62 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
hehe bash test scripts
8629058 to
54c2fc2
Compare
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Lands the coverage the previous PR's docs had prematurely claimed: - Add a cu130 matrix row to container-build.yml so release images are actually built and published for both CUDA variants. - Fix the cu130 GPU e2e lane, which silently re-bootstrapped cu129 via .mise/tasks/tests.toml's hardcoded bootstrap-nss call before running, so it tested cu129 twice instead of exercising cu130 at all. The e2e tasks now bootstrap $NSS_GPU_CUDA_EXTRA (default cu129, unchanged for local/other callers), and gpu-tests.yml sets it from the matrix. - Flip docs, workflow diagram, and skip messages back to accurately describe cu130 as enabled now that both are true. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
029bd8f to
773a0af
Compare
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
…#655) ## Summary this is one of three stacked prs (NVIDIA-NeMo#656, NVIDIA-NeMo#657) for our overdue multiple-versions-of-cuda support. This one is the core mechanism for generating the deps all from one place and handles instructions and docs for new installation methods. - Define CPU and CUDA runtime extras, conflicts, package sources, and indexes in cuda_deps.toml. - Generate the corresponding marked pyproject.toml sections from that single source of truth. ## Validation ``` - uv run --offline --script tools/gen_cuda_deps.py cuda_deps.toml --pyproject pyproject.toml --check - uv lock --check ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary * **New Features** * Introduced a tool-managed workflow for CPU/CUDA runtime extras via `cuda_deps.toml`, with automatic regeneration of dependency lists and package source/index metadata. * Added a `--check`/lock-check flow to prevent CUDA metadata drift. * **Documentation** * Updated contributor, agent, README, Docker, and CI guidance to regenerate from `cuda_deps.toml` and keep the lockfile in sync. * **Quality & Tests** * Added end-to-end coverage for generation, splicing, idempotency, and error cases. * **Chores / Style** * Added `dprint`-based TOML formatting and expanded CI formatting checks. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com> Co-authored-by: Claude <noreply@anthropic.com>
Summary
Validation
Final PR in the CUDA 13 stack; depends on #656.