Draft: Feat: Enable torch compile #496
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Zhang <[email protected]>
terrykong
reviewed
Jun 10, 2025
There was a problem hiding this comment.
Could you add this key to all the configs/recipes?
terrykong
reviewed
Jun 10, 2025
|
@jiemingz is the only thing blocking this PR the seq-packing change since we need static shapes for torch.compile? |
|
Dependent on #300 |
|
Dtensor sequence packing has been merged. @ahmadki to support max-padding packed sequences in DTensor to enable torch.compile (fixed seqlen). |
StrongerXi
reviewed
Jul 29, 2025
| @@ -195,6 +196,9 @@ def __init__( | |||
| custom_parallel_plan=self.cfg["dtensor_cfg"]["custom_parallel_plan"], | |||
| ) | |||
|
|
|||
| if self.torch_compile: | |||
| self.model = torch.compile(model) | |||
There was a problem hiding this comment.
Could you try model.compile() instead? That should fix the _orig_mod issue. This is also the recommended way of compiling a model now. We'll work on throwing warnings and publicizing to raise awareness on this.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information