Cloud IO Improvements #1226
Draft
Cloud IO Improvements #1226
+46
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praateek <[email protected]>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Praateek <[email protected]>
sarahyurick
reviewed
Nov 10, 2025
Comment on lines
61
to
62
| # TODO : I think we can remove this | ||
| self.fs = get_fs(self.ids_to_remove_path, storage_options=self.read_kwargs.get("storage_options", {})) |
|
|
||
| # TODO generating filesystem for each task will be inefficient, we should benchmark pq.read_table # noqa: TD004 | ||
| fs = get_fs(paths[0], storage_options=read_kwargs.get("storage_options", {})) | ||
| # pop storage_options from read_kwargs |
Contributor
There was a problem hiding this comment.
Can you add a more explanatory comment here?
Contributor
Author
There was a problem hiding this comment.
iirc this was because pd.read_parquet(list_of_files) fails for cloud paths.. the hack was using filesystem=fs.. i think for now we shouldn't do this but rather pd.concat([pd.read_parquet(f) for f in files])
praateekmahajan
commented
Nov 13, 2025
| # Add any additional kwargs, allowing them to override defaults | ||
| write_kwargs.update(self.write_kwargs) | ||
| df.to_parquet(file_path, **write_kwargs) | ||
| # Pop storage_options as we're directly passing the filesystem to the writer |
Contributor
Author
There was a problem hiding this comment.
forgotten why do we need filesystem here? would prefer to not pass filesystem
Signed-off-by: Praateek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Usage
# Add snippet demonstrating usageChecklist