Add general Chi2 script and README#102
Open
02-infinity wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi Shivanshi, I'm not entirely convinced this needs to be committed to NUISANCE itself. What is the use case for it? It computes a chi2 between a data and a prediction MC with an arbitrary matrix? This seems like a user feature that can be expressed in a few lines of ROOT linear algebra in user analysis. What is the general use case? If there is one we are happy to accept the PR, but it's format needs to change, the new fils ot merge are currently not in a standard location or included in the buildsystem and the readme is not super clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Evaluate Fit Performance of the model: We have taken the data and best fit MC with six parameters (using nuismin) involving the sum of Diagonal Covariance Matrix and off diagonal elements of PCA1 matrix but instead of using the covariance from the same file, we have used the full covariance matrix from the nominal nuiscomp file. So basically, “External” matrix is used to compute chi-square for the data-MC difference vector, instead of the “internal” covariance from the same file as data-MC. This code and README file is all about that.
Data/MC: MicroBooNE CC1u1p (Muon Momentum, MuonCosTheta, Proton momentum, ProtonCosTheta)
GENIE + AR23 tune