Merged
Conversation
Collaborator
|
good, function work! |
weiber2002
approved these changes
Mar 19, 2025
Collaborator
weiber2002
left a comment
There was a problem hiding this comment.
good, function works!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
CIcon does not show throughout local website. This PR solves this problem.
What type of PR is it?
Bug Fix
The problem is:
CIcon does not show throughout local website. Basically EVERY doesn't show.
After some experiments, I've found that:
<CIcon icon="cil-menu"/>doesn't work, but<CIcon icon={React.icons.cilMenu}/>works.I'm not sure why this happen. A few years ago there's no such problem but now.
Here's some assumptions:
For assumption 1, I've tried:
The above approaches fail to solve this problem. Hence, I would rather believe that the "string" API is no more supported though I find no documentation stating this issue.
What I actually did is:
simply turn each
<CIcon icon="whatever-icon-it-is"/>into<CIcon icon={React.icons.whateverIconItIs}/>, 135 icons in total.What is the Jira issue?
(btw, our Jira seems broken)