Skip to content

Localization draft #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Localization draft #53

wants to merge 17 commits into from

Conversation

eMukator
Copy link
Collaborator

Hi Josh,
this is a draft of localization for the wiki. So far only partially Layout and fully Login and Registration pages, including models. Take a look and judge for yourself if this is the right way to go and worth implementing into TightWiki. I am not against suggestions for changes. I'll finish it in a fork anyway.
Thanks,
Milan

@NTDLS
Copy link
Owner

NTDLS commented May 17, 2025

Holy crap! I'll check this out in the morning. Fantastic work!

@NTDLS NTDLS self-assigned this May 17, 2025
@NTDLS NTDLS marked this pull request as ready for review May 21, 2025 19:48
NTDLS
NTDLS previously approved these changes May 21, 2025
Copy link
Owner

@NTDLS NTDLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is amazing. I'm going to merge it and test in the main branch when you are ready. Insane I know.

@NTDLS NTDLS self-requested a review May 21, 2025 20:01
@NTDLS NTDLS dismissed their stale review May 21, 2025 20:02

Didn't mean to approve - only comment.

@NTDLS
Copy link
Owner

NTDLS commented May 21, 2025

@eMukator would we be able to use the same approach for views such as this (in addition to the pages)?

image

@eMukator
Copy link
Collaborator Author

@NTDLS Of course. I've prepared localization for ProfileController and its views, so take a look. I'll continue, I just need more time. I have a lot of work until the end of May.

@NTDLS
Copy link
Owner

NTDLS commented Jun 3, 2025

I like the approach a lot. Is this ready for test and merge?

@eMukator
Copy link
Collaborator Author

eMukator commented Jun 3, 2025

Sorry, I still have to finish the Page controller and its views, but you can test it anyway.
I would like to have all the language resources in a separate project, but I haven't managed to do that yet.

@eMukator
Copy link
Collaborator Author

eMukator commented Jun 3, 2025

I gave it more time and the translations are done... but there are errors related to internal number conversion. The Czech format uses a comma as a decimal separator, so the number 0.6 is not a valid format and should be 0,6 - and therefore all internal conversions from string to number/date/time must be performed as InvariantCulture. The error appears on the search page when switching to the Czech language. I am afraid that this is not the only occurrence and more thorough testing will be needed.

@eMukator
Copy link
Collaborator Author

eMukator commented Jun 3, 2025

Request: /Page/Search?SearchString=figure,
RouteValues: [action, Search],
[controller, Page],

  System.Exception: Error converting value [0.60] to float.
     at NTDLS.Helpers.Converters.ConvertTo[T](String value)

@NTDLS
Copy link
Owner

NTDLS commented Jun 13, 2025

Other than the errors with the decimal conversions, this looks good to me. I'd be happy to merge it and work on the additional issues in a separate branch. Sound good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants