-
Notifications
You must be signed in to change notification settings - Fork 5
Localization draft #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Holy crap! I'll check this out in the morning. Fantastic work! |
…pages into Czech and Slovak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is amazing. I'm going to merge it and test in the main branch when you are ready. Insane I know.
@eMukator would we be able to use the same approach for views such as this (in addition to the pages)? |
@NTDLS Of course. I've prepared localization for ProfileController and its views, so take a look. I'll continue, I just need more time. I have a lot of work until the end of May. |
…thout wiew models
I like the approach a lot. Is this ready for test and merge? |
Sorry, I still have to finish the Page controller and its views, but you can test it anyway. |
I gave it more time and the translations are done... but there are errors related to internal number conversion. The Czech format uses a comma as a decimal separator, so the number 0.6 is not a valid format and should be 0,6 - and therefore all internal conversions from string to number/date/time must be performed as InvariantCulture. The error appears on the search page when switching to the Czech language. I am afraid that this is not the only occurrence and more thorough testing will be needed. |
Request: /Page/Search?SearchString=figure,
|
Other than the errors with the decimal conversions, this looks good to me. I'd be happy to merge it and work on the additional issues in a separate branch. Sound good? |
Hi Josh,
this is a draft of localization for the wiki. So far only partially Layout and fully Login and Registration pages, including models. Take a look and judge for yourself if this is the right way to go and worth implementing into TightWiki. I am not against suggestions for changes. I'll finish it in a fork anyway.
Thanks,
Milan