Add more unit tests for threaded services tests #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed.py, covering cache hashing, extensionless moves, debug-only writes, disk writers, usage/jurisdiction updaters, and HTML loader flows so the module now hits all conditional paths.
ppinchuk
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 40.02% 42.19% +2.16%
==========================================
Files 45 45
Lines 4240 4240
Branches 380 380
==========================================
+ Hits 1697 1789 +92
+ Misses 2523 2434 -89
+ Partials 20 17 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Copilot finished reviewing on behalf of
ppinchuk
November 20, 2025 21:38
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit test coverage for the threaded services module, testing various file caching, writing, and processing utilities used by the COMPASS project.
- Adds 18 new test functions covering private utility functions and service classes
- Tests file caching with hash computation, file moving operations, cleaned file writing, ordinance database writing, and HTML file loading
- Includes tests for services like
TempFileCache,TempFileCachePB,CleanedFileWriter,OrdDBFileWriter,UsageUpdater, andJurisdictionUpdater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly working toward the goal of 80%+ coverage