Remove synch condensers#5
Open
rbolgaryn wants to merge 2 commits intoNREL-Sienna:remove-synch-condensersfrom
Open
Remove synch condensers#5rbolgaryn wants to merge 2 commits intoNREL-Sienna:remove-synch-condensersfrom
rbolgaryn wants to merge 2 commits intoNREL-Sienna:remove-synch-condensersfrom
Conversation
luke-kiernan
reviewed
May 9, 2025
Collaborator
luke-kiernan
left a comment
luke-kiernan
left a comment
There was a problem hiding this comment.
Could you remove the changes related to PSY 4 -> PSY 5 migration?
| "Geothermal" => ThermalFuels.GEOTHERMAL, | ||
| "Nuclear" => ThermalFuels.NUCLEAR, | ||
| "Wood/Wood Waste Biomass" => ThermalFuels.WOOD_WASTE, | ||
| "Wood/Wood Waste Biomass" => ThermalFuels.WOOD_WASTE_SOLIDS, |
Collaborator
There was a problem hiding this comment.
This is a compatibility-breaking PSY 4 -> PSY 5 change. I feel it's too soon to make that switch. Jose is still ironing out the bugs in PSY 5; the main branch of other projects in the Sienna ecosystem are all still on PSY 4. You could merge this into a new psy5 branch...but I'd prefer to simply remove the compatibility-breaking PSY 5 changes for now.
Member
|
@luke-kiernan and @rbolgaryn can we get this to PSY5 too please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the branch with the latest scripts for CATS