Power factor fixed, added uced#3
Power factor fixed, added uced#3hannahchubin wants to merge 14 commits intoremove-synch-condensersfrom
Conversation
Hc/merging replace gens
luke-kiernan
left a comment
luke-kiernan
left a comment
There was a problem hiding this comment.
I left comments with the 2 biggest issues that jumped out at me--please fix those.
assemble_system/UCED_1o_HS.jl
Outdated
|
|
||
| mip_gap = 0.001 | ||
|
|
||
| sys_path = "assemble_system/CATS_1o.json" |
There was a problem hiding this comment.
When I run this on my machine, I get an error: LoadError: SQLite.SQLiteException("no such column: owner_uuid"). I don't think these .json and .h5 files are portable: CATS_1o.json includes paths like "source":"/Users/hsun2/.julia/packages/ForwardDiff/UBbGT". Can you instead build the system from a MATPOWER file?
There was a problem hiding this comment.
This file is identical to the one already in data. Either use the existing one, or if you want to reorganize things, move it to a new location. Similar comments apply for many of the other files: generally, modify or move things, instead of making copies. e.g. just modify parse-matpower.jl, instead of creating parse-matpower_1o.jl Otherwise, it's unclear which one is the up-to-date, working script, and which is the old, non-functional one. Also, git cooperates much better with modifications: it compares to the old version and highlights changes.
2 participants
No description provided.