Skip to content

🐞 Fix diatomic transform#465

Open
Alexsp32 wants to merge 4 commits intomainfrom
unitary-diatomic-transform
Open

🐞 Fix diatomic transform#465
Alexsp32 wants to merge 4 commits intomainfrom
unitary-diatomic-transform

Conversation

@Alexsp32
Copy link
Copy Markdown
Member

@Alexsp32 Alexsp32 commented Mar 10, 2026

  • Fix flipped indices and other mistakes in internal coordinate transform matrix that was causing transform_to_internal_coordinates to give nonsensical numbers.
  • Add a unit test which ensures forward transform ⋅ back transform retain the original matrix.
  • Add unit test to ensure transform matrix is unitary

@Alexsp32 Alexsp32 self-assigned this Mar 10, 2026
@Alexsp32 Alexsp32 force-pushed the unitary-diatomic-transform branch from d6ab9a9 to 1539f4d Compare March 16, 2026 07:23
@Alexsp32 Alexsp32 mentioned this pull request Mar 16, 2026
3 tasks
@Alexsp32 Alexsp32 force-pushed the unitary-diatomic-transform branch 2 times, most recently from d6d55aa to 133c699 Compare March 18, 2026 07:49
@Alexsp32 Alexsp32 force-pushed the unitary-diatomic-transform branch from 4bbab76 to d1f606f Compare March 20, 2026 13:09
@Alexsp32 Alexsp32 force-pushed the unitary-diatomic-transform branch from 6cede92 to 8286207 Compare April 15, 2026 08:08
@Alexsp32 Alexsp32 force-pushed the unitary-diatomic-transform branch from 8286207 to a46ff80 Compare April 15, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant