[Fix]: Separation of conditionals for selecting radiation in Physics call#98
[Fix]: Separation of conditionals for selecting radiation in Physics call#98fmalatino wants to merge 2 commits into
Physics call#98Conversation
…sable parsing of radiation by orchestration
oelbert
left a comment
There was a problem hiding this comment.
Great, thanks for fixing this Frank
|
Technical detail here: for orchestration the |
That's correct, |
oelbert
left a comment
There was a problem hiding this comment.
One small change, ideally we'd have the compile-time conditional before the runtime one
| if do_radiation: | ||
| if self._rterrtmgp: |
There was a problem hiding this comment.
Could we reverse the order of these conditionals so the compile-time one is first?
| self._level_flip, | ||
| ) | ||
|
|
||
| self._interpolate_radiation( |
There was a problem hiding this comment.
This should be outside the if do_radiation condition
Description
This PR introduces changes to allow orchestration to parse the
Physicsobject call, without entering into the block regarding radiation.How Has This Been Tested?
Tested using current CI
Checklist: