[production/RRFS.v1] fix RRFS/REFS restart reproducibility issues #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will restore restart reproducibility of RRFSv1 when using saSAS deep convection and progsigma. The change will add the correct logic when initializing sigmab (the updraft area fraction). Although not being turned on in RRFSv1, saSAS shallow convection is also modified accordingly for consistency. This PR has no impact on warm start runs. Co-authored-by: jili dong <[email protected]>
* fix for snow water equivalent accumulation restart reproducibility
Rrfs v1 conus13km tests
Add write grid comp. restart support for fv_diag.res file
* update ccpp/physics --------- Co-authored-by: jili dong <[email protected]> Co-authored-by: jili dong <[email protected]>
MatthewPyle-NOAA
approved these changes
Oct 14, 2025
Collaborator
MatthewPyle-NOAA
left a comment
MatthewPyle-NOAA
left a comment
There was a problem hiding this comment.
Looks okay to me based on a quick scanning of the changes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes RRFS/REFS restart bitwise reproducibility issues caused by:
Big thanks to @DusanJovic-NOAA for all his help and work!
The forecast will only change when Grell-Freitas is turned on during warm start runs with gf_coldstart being explicitly set to T in the namelist
This PR also includes a hook to output surface specific humidity, which may be needed for RRFS post-processing.
Issue(s) addressed
#1020
Testing
How were these changes tested?
The changes have been tested with RRFS real case from real-time runs over a large north America domain.
What compilers / HPCs was it tested with?
WCOSS2 with intel compiler
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
The changes are partially covered by regression test. To fully include these changes in regression tests, we need cases with winter weather (snow accumulation) and strong convection cases (strong updraft). Regression tests covering all REFS ensemble members are also needed.
Have the ufs-weather-model regression test been run? On what platform?
No for the current RTs.
Dependencies
NOAA-EMC/GFDL_atmos_cubed_sphere#91
ufs-community/ccpp-physics#315