Add marine LEKTF workflow support#2175
Conversation
There was a problem hiding this comment.
Pull request overview
This PR is a draft companion to global-workflow changes, intended to add/enable marine LETKF workflow support and related recentering/ensemble-increment handling in GDASApp’s marine configuration templates.
Changes:
- Updates marine workflow YAML templates to stage/route LETKF increment outputs into analysis COM locations and to stage recentering inputs (increments/analysis).
- Extends marine LETKF configuration to include additional sea-ice increment variables and enables saving posterior ensemble increments.
- Adds a JCB marine output template for ensemble increments and introduces
marine_letkf_app-conditioned behavior in marine JCB templates.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| parm/marine/marine_ens_config.yaml.j2 | Updates LETKF staging/output paths and switches per-resolution fix template inclusion to zero-padded OCNRES. |
| parm/marine/marine_ecen_config.yaml.j2 | Adds staging for LETKF increments/analysis for ensemble recentering and updates fix-template inclusion formatting. |
| parm/marine/marine_det_config.yaml.j2 | Zero-pads OCNRES when including the marine fix staging template. |
| parm/marine/marine_bmat_config.yaml.j2 | Zero-pads OCNRES when including the marine fix staging template. |
| parm/marine/jcb-base.yaml.j2 | Adds ice thickness variables and enables saving posterior ensemble increments for marine LETKF driver settings. |
| parm/jcb-gdas/model/marine/marine_output_ensemble_increments.yaml.j2 | Introduces a marine model output template intended for ensemble increment output. |
| parm/jcb-gdas/model/marine/marine_background_ensemble.yaml.j2 | Conditions ensemble state variable lists on LETKF-app mode (and adds additional ice variables for that path). |
| parm/jcb-gdas/algorithm/marine/soca_ens_handler.yaml.j2 | Adds LETKF-app-conditioned behavior for increment variables, optional analysis-increment inputs, and recentering background selection. |
|
@AndrewEichmann-NOAA : The CI failure was due to soca compilation issues. Not sure why this happened. I will log into Ursa role.jedipara and manually rerun CI to troubleshoot. |
|
Automated GW-GDASApp Testing Results: |
|
Automated GW-GDASApp Testing Results: |
|
Not sure if the following is the problem, but it's something I noticed:
I would update |
| - sea_ice_thickness | ||
| - sea_ice_snow_thickness | ||
|
|
||
| {% if marine_letkf_app | default(false) %} |
There was a problem hiding this comment.
I think we only need this when we have DOLETKF_OCN_INC, is the check consistent here?
There was a problem hiding this comment.
I thought it was internally necessary to the soca yamls, it's set if DOLETKF_OCN_INC or DOLETKF_OCN are YES (I think)
| {% if not marine_letkf_app | default(false) %} | ||
| - eastward_sea_water_velocity | ||
| - northward_sea_water_velocity | ||
| {% endif %} |
There was a problem hiding this comment.
I think we can just remove the velocities altogether, for both with and without LETKF cases.
I would however ignore this comment (because it requires more testing, and it's probably easier to not do it at this point), not very important.
There was a problem hiding this comment.
I seem to recall some problems with doing this, maybe elsewhere?
|
@lslivins That would be for the g-w PR - I'm unsure how that would interact with the needs of OMD, can we make that a separate PR for the future? |
|
Hash updated in g-w, trying again |
|
Automated GW-GDASApp Testing Results: |
Description
Companion PR to NOAA-EMC/global-workflow#4789 to add marine LETKF to workflow and recenter increments around deterministic background to initialize ensemble.
Companion PRs
NOAA-EMC/global-workflow#4789
Issues
NOAA-EMC/global-workflow#5025
Also resolves #2155
Automated CI tests to run in Global Workflow