Turn off randomly set up inflation within LETKF#2146
Open
shlyaeva wants to merge 3 commits into
Open
Conversation
JohnSteffen-NOAA
approved these changes
May 19, 2026
AndrewEichmann-NOAA
approved these changes
May 20, 2026
AndrewEichmann-NOAA
left a comment
AndrewEichmann-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
A good start
Collaborator
Author
|
@guillaumevernieres, @AndrewEichmann-NOAA ok to merge this? I don't think we need to run the tests for this change (famous last words). |
Collaborator
I have no objections |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inflation was set up randomly for marine LETKF (whatever was set in the soca test yamls, which is definitely not what we'll want to do in real runs). This turns all of the inflation off for now (before we've tuned the inflation for cycled experiments) to remove the effect of inflation while we're evaluating LETKF.
Automated CI tests to run in Global Workflow