Correct mismatched parms for IMS converter#2119
Draft
yuanxue2870 wants to merge 1 commit into
Draft
Conversation
Collaborator
ClaraDraper-NOAA
left a comment
There was a problem hiding this comment.
These parameters were reduced in the first place as the assimilation of snow cover for high MFsnow can blow up the snow depth (since the model can't generate 100% snow depth, but the obs can). The real issue is that these parameters need to be reduced in the model, but that will likely have negative consequences on the temperatures and will require some time to figure out.
For now, the best solution is to add QC to the IMS DA to not assimilate the snow cover data over the affected vegetation types. @yuanxue2870 please close this PR, and when you're ready open one that excludes the IMS obs over the problematic vegetation types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mismatched mfsno parameters for certain veg type were found between IMS coverter table and currently-used v17 Noah-MP table (https://github.com/ufs-community/ccpp-physics/blob/91d979065ed41ef9503b837b42ac0850d71cc6b0/physics/SFC_Models/Land/Noahmp/noahmptable.tbl). The mismatch forces model to loss snow at the next forecast step and yield consistently positive snodl increments especially when the snow density is high.
Companion PRs
N/A
Issues
Resolves #2112
Automated CI tests to run in Global Workflow