-
Notifications
You must be signed in to change notification settings - Fork 1
Lesson 2 cleanup #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lesson 2 cleanup #187
Conversation
theangchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo under Explaination for TimePicker:
defaultValue={formDatastartTime}
should be:
defaultValue={formData.startTime}
theangchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaygiang This looks good. I was able to step through Lesson 2 ✅
- Just need fix the 1 typo
- Make sure the imports we're supposed to add in this lesson are removed in StartTrip.jsx
- Double check the line numbers are correct for the FormGroup in StartTrip.jsx. It was close but slightly off for me.
Otherwise good to go.
docs/learn/lesson-2.mdx
Outdated
| * `minTime`, `maxTime`, and `step={15}` configure the available time options (from 00:00 to 23:30 in 15-minute increments). | ||
| * `validationStatus` and `className` are used for conditional error styling, similar to the `DatePicker`. | ||
| - Similar to the `DatePicker`, we use `FormGroup` and `Label` for structure and accessibility | ||
| - `defaultValue={formDatastartTime}` binds the input to the `startTime` field in our state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here. Should be:
defaultValue={formData.startTime}
|
Thanks @theangchen! I made the typo update. Also, I'll write those notes down for when I update the learn-radfish startTrip.jsx file. |
Improves the structure, clarity, and completeness of the "Lesson 2: Start Trip Form Inputs" tutorial documentation.
Structure and Formatting
###for subsections)1.1,1.2,2.1,2.2, etc.)//diff-add-startand//diff-add-endtagsContent Enhancements
TimePicker,Select)TimePickerexample with corrected properties:maxTimefrom"23:30"to"23:45"requiredMarkerproperty instead of manual<span>elementsTechnical Accuracy
onChangehandler for clarity