Skip to content

Conversation

@jaygiang
Copy link
Collaborator

Improves the structure, clarity, and completeness of the "Lesson 2: Start Trip Form Inputs" tutorial documentation.

Structure and Formatting

  • Improved heading hierarchy using proper markdown levels (### for subsections)
  • Added consistent section numbering (1.1, 1.2, 2.1, 2.2, etc.)
  • Highlighted code additions using //diff-add-start and //diff-add-end tags
  • Standardized line numbering in code examples to match actual file positions

Content Enhancements

  • Added dedicated import sections for each component (TimePicker, Select)
  • Updated TimePicker example with corrected properties:
    • Changed maxTime from "23:30" to "23:45"
    • Replaced error handling attributes with simplified version
    • Used proper requiredMarker property instead of manual <span> elements
  • Added a complete form example showing all three inputs together
  • Updated all code examples to reflect the actual implementation

Technical Accuracy

  • Add explanation for state management and onChange handler for clarity
  • Removed references to validation(will be handled in lesson 5)

@jaygiang jaygiang requested review from theangchen and thgaskell May 27, 2025 23:01
@theangchen theangchen moved this to Needs Review in RADFish Project Board May 27, 2025
@jaygiang jaygiang changed the base branch from main to lesson-1-cleanup May 27, 2025 23:07
@theangchen theangchen added the Learning Mod Learning module on docs label May 28, 2025
Copy link
Collaborator

@theangchen theangchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo under Explaination for TimePicker:
defaultValue={formDatastartTime}
should be:
defaultValue={formData.startTime}

Copy link
Collaborator

@theangchen theangchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaygiang This looks good. I was able to step through Lesson 2 ✅

  • Just need fix the 1 typo
  • Make sure the imports we're supposed to add in this lesson are removed in StartTrip.jsx
  • Double check the line numbers are correct for the FormGroup in StartTrip.jsx. It was close but slightly off for me.

Otherwise good to go.

* `minTime`, `maxTime`, and `step={15}` configure the available time options (from 00:00 to 23:30 in 15-minute increments).
* `validationStatus` and `className` are used for conditional error styling, similar to the `DatePicker`.
- Similar to the `DatePicker`, we use `FormGroup` and `Label` for structure and accessibility
- `defaultValue={formDatastartTime}` binds the input to the `startTime` field in our state
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here. Should be:
defaultValue={formData.startTime}

@jaygiang
Copy link
Collaborator Author

Thanks @theangchen! I made the typo update. Also, I'll write those notes down for when I update the learn-radfish startTrip.jsx file.

@jaygiang jaygiang merged commit 63d5cad into lesson-1-cleanup May 29, 2025
@jaygiang jaygiang deleted the lesson-2-cleanup branch May 29, 2025 21:59
@theangchen theangchen moved this from Needs Review to Done in RADFish Project Board May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Learning Mod Learning module on docs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants