660 Allow user to define network status handler #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgaskell
previously approved these changes
Sep 11, 2025
| mocks: { | ||
| handlers: import("../mocks/browser.js"), | ||
| }, | ||
| network: { |
Contributor
There was a problem hiding this comment.
The default template shouldn't set a handler for the developer.
packages/radfish/index.js
Outdated
| this._registerEventListeners(); | ||
|
|
||
| // Check initial network status if handler provided | ||
| if (this._networkHandler) { |
Contributor
There was a problem hiding this comment.
Should check if options.network.onChange is a function.
thgaskell
previously approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #660
Custom Network Handler:
Introduces a new
networkproperty allowing users to provide a customsetIsOnlinefunction for checking connectivity. If provided, it overrides the defaultnavigator.onLinecheck.Event Handling:
Updates the application to use browser
online/offlineevents. If a custom handler exists, it verifies connectivity before dispatching"online"or"offline"events; otherwise, it falls back tonavigator.onLine.React Integration:
The network status updates are consumed by the React hook
useOfflineStatusto update the UI.