Reject empty TXT records in Txt::parse - #709
Open
SebastiaanYN wants to merge 1 commit into
Open
Conversation
RFC 1035 section 3.3.14 requires "one or more" character strings, so rdlength=0 is invalid. `check_slice` (used by `from_octets` / `from_slice`) already enforced this; `parse` did not, allowing construction of a `Txt` that panics in `as_flat_slice`. Replace the manual `CharStr::skip` loop with a single `check_slice` call so all construction paths share the same validation. The zero-length unknown-rdata test now uses TYPE65534 instead of TXT since zero-length TXT is correctly invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Txt::parseallows empty TXT records, which breaks the assumption inas_flat_slicethat there's always at least one character.Replace the manual
CharStr::skiploop with a singlecheck_slicecall so all construction paths share the same validation.The zero-length unknown-rdata test now uses TYPE65534 instead of TXT since zero-length TXT is correctly invalid.