Fix name compressors emitting wrong pointers past 14-bit offset limit - #707
Open
SebastiaanYN wants to merge 1 commit into
Open
Fix name compressors emitting wrong pointers past 14-bit offset limit#707SebastiaanYN wants to merge 1 commit into
SebastiaanYN wants to merge 1 commit into
Conversation
All three compressors used `0xC000` (16 bits) as the maximum position for storing name offsets. The correct limit is `0x4000` (14 bits), because the top 2 bits of a compression pointer are the `0xC0` marker. Positions between 0x4000 and 0xBFFF produced pointers that decode to the wrong offset, corrupting owner names. Introduce `MAX_COMPRESSION_OFFSET` (`1 << 14`) and use it in all insert and truncate methods of `StaticCompressor`, `TreeCompressor`, and `HashCompressor`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All three compressors used
0xC000(16 bits) as the maximum position for storing name offsets. The correct limit is0x4000(14 bits), because the top 2 bits of a compression pointer are the0xC0marker. Positions between 0x4000 and 0xBFFF produced pointers that decode to the wrong offset, corrupting owner names.Introduce
MAX_COMPRESSION_OFFSET(1 << 14) and use it in all insert and truncate methods ofStaticCompressor,TreeCompressor, andHashCompressor.